Re: Patches and a .po file

["Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>]

Thanks, updates applied.

Regards Dave 

> -----Original Message-----
> From: Guillaume Lelarge [mailto:guillaume(at)lelarge(dot)info] 
> Sent: 27 September 2006 23:39
> To: Dave Page
> Cc: pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] Patches and a .po file
> 
> Dave Page a écrit :
> > [...]
> >>  - frmReport : the object type is now translated on the 
> report and I
> >> added a dash before the report's type because it was not 
> >> translatable in
> >> french as is, but it is now... and it is still good english 
> >> (at least, I
> >> hope so).
> > 
> > It doesn't look great actually. I think the correct fix is something
> > more like:
> > 
> > title.Printf(_("%s DDL Report - "), object->GetTypeName());
> > title += object->GetIdentifier();
> > report->SetReportTitle(title);
> > 
> > Then you can translate 
> > 
> > _("%s DDL Report - ")
> > 
> > To
> > 
> > _("DDL Report %s - ")
> > 
> > Or whatever is actually right in French. Can you update you 
> patch if you
> > agree please?
> > 
> 
> You'll find a new patch attached.
> 
> > BTW, I *haven't* committed your translation update yet in case it
> > contains strings you're about to remove.
> > 
> 
> The .po is also attached. It contains the new strings.
> 
> Regards.
> 
> PS : I checked your fix, it works great. Thanks.
> 
> 
> -- 
> Guillaume.
> <!-- http://abs.traduc.org/
>      http://lfs.traduc.org/
>      http://traduc.postgresqlfr.org/ -->
>