Re: SUN Studio 11 vs pgAdmin - code cleanup]

["Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>]

> -----Original Message-----
> From: Zdenek(dot)Kotala(at)Sun(dot)COM [mailto:Zdenek(dot)Kotala(at)Sun(dot)COM] 
> Sent: 02 August 2006 07:33
> To: pgadmin-hackers(at)postgresql(dot)org; Dave Page
> Subject: SUN Studio 11 vs pgAdmin - code cleanup]
> 
> 
> I tried compiled pgAdmin with the SUN Studio 11 and I found 
> some problem
> in the code. I send patch which fix two errors and lot of warnings:
> 
> 1) New C++ standard brings overloaded definition of strchr 
> function. See
>    http://www.cplusplus.com/ref/cstring/strchr.html for detail.
> 
> 2) Missing const in the pgCollection::FindChild method definition
> generate mangling problem with linking. See
> http://developers.sun.com/prodtech/cc/documentation/ss11/mr/RE
> ADMEs/c++.html#cNameMangling
> 
> 3) I removed extra ; in the code on many places.

Thanks - patch applied to the stable branch. Would you mind taking some
time to port the patch to SVN TRUNK please? It's most likely that that
will go beta within a few weeks and unfortunately I'm *really* pushed
for time right now :-(

> There are still many warnings about hiding virtual functions,
> attributes... I think It is not good practice but it works.
> 
> I have still problem with building (autoconf/automake). There are hard
> coded switches related to the gcc compiler. I would like to 
> fix it, but
> I'm not familiar with automake/autoconf. Is there anybody who can help
> me wit it?

I can certainly try - what do you need to change? (BTW, build system
changes like this will only be applied to trunk - I consider support for
a new compiler to be a new feature, especially when we already have an
option for the target platform).

Regards, Dave.