Re: [patch] Please drop the dangerous libssl and libcrypto deps

[Andreas Pflug <pgadmin(at)pse-consulting(dot)de>]

Raphaël Enrici wrote:
> Dear friends,
>
> Loic Minier(CCed) provided a patch to prevent pgadmin3 1.2.2 from being
> linked to a different libssl version than libpq when dynamically built
> with an already ssl enabled libpq. The full bug report and original
> patch by Loic can be found at
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=341117
>
> Attached is an svn diff for 1.4.1 release that I'm using for the package
> I'm about to upload to Debian (patch_libpqssl_1.4.1).
> You'll also find a fully untested patch for trunk (patch_libpqssl_current).
>
> Please recheck and apply if eveything's ok with them.
>
> Cheers,
> Raph
>
>
> ------------------------------------------------------------------------
>
> Index: acinclude.m4
> ===================================================================
> --- acinclude.m4	(revision 4858)
> +++ acinclude.m4	(working copy)
> @@ -227,7 +227,10 @@
>      else
>          if test "$pgsql_ssl_libpq" = "yes"
>          then
> -            LIBS="$LIBS -lssl -lcrypto -lpq"
> +	    # no idea why -lssl and -lcrypto were included here, as this
> +            # support is provided via libpq
> +            #LIBS="$LIBS -lssl -lcrypto -lpq
> +            LIBS="$LIBS -lpq"
>          else
>              LIBS="$LIBS -lcrypto -lpq"
>          fi

We probably need this with static linking?

Regards,
Andreas