Re: CVS Commit by andreas: gcc3.4 workaround

[Raphaël Enrici <blacknoz(at)club-internet(dot)fr>]

Dave Page wrote:
>  
>
>
> > -----Original Message-----
> > From: pgadmin-hackers-owner(at)postgresql(dot)org 
> > [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of 
> > cvs(at)cvs(dot)pgadmin(dot)org
> > Sent: 16 August 2004 15:43
> > To: pgadmin-hackers(at)postgresql(dot)org
> > Subject: [pgadmin-hackers] CVS Commit by andreas: gcc3.4 workaround
> >
> > Log Message:
> > -----------
> > gcc3.4 workaround
> >
> > Modified Files:
> > --------------
> >    pgadmin3/src/include:
> >        dlgClasses.h (r1.6 -> r1.7)
>
>
> Is this the cause of:

Yes I think so.

Andreas, it seems you missed something with the patch or maybe I just 
provided a bad one.

What I see in dlgClasses.h is:

#if __GNUC__ >= 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4)
public:
    void OnOK(wxCommandEvent& ev);
    void OnCancel(wxCommandEvent& ev);
    void OnClose(wxCloseEvent& event);
protected:
#endif


IMHO It should be:
#if __GNUC__ >= 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4)
public:

#endif
    void OnOK(wxCommandEvent& ev);
    void OnCancel(wxCommandEvent& ev);
    void OnClose(wxCloseEvent& event);
protected:


Regards,
Raphaël

> Compiling...
> ctlSQLBox.cpp
> dlgClasses.cpp
> C:\Documents and Settings\dpage\My
> Documents\CVS\pgadmin3\src\ui\dlgClasses.cpp(300) : error C2509: 'OnOK'
> : member function not declared in 'ExternProcessDialog'
>         include/dlgClasses.h(99) : see declaration of
> 'ExternProcessDialog'
> C:\Documents and Settings\dpage\My
> Documents\CVS\pgadmin3\src\ui\dlgClasses.cpp(346) : error C2509:
> 'OnCancel' : member function not declared in 'ExternProcessDialog'
>         include/dlgClasses.h(99) : see declaration of
> 'ExternProcessDialog'
> C:\Documents and Settings\dpage\My
> Documents\CVS\pgadmin3\src\ui\dlgClasses.cpp(358) : error C2509:
> 'OnClose' : member function not declared in 'ExternProcessDialog'
>         include/dlgClasses.h(99) : see declaration of
> 'ExternProcessDialog'
>
> Regards, Dave.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
>       message can get through to the mailing list cleanly