Re: Bug in CREATE USER script

[Darko Prenosil <darko(dot)prenosil(at)finteh(dot)hr>]

Here it is as I promised !
Regards !

On Saturday 14 August 2004 00:41, Dave Page wrote:
> > -----Original Message-----
> > From: pgadmin-hackers-owner(at)postgresql(dot)org
> > [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> > Darko Prenosil
> > Sent: 13 August 2004 21:59
> > To: pgadmin-hackers(at)postgresql(dot)org
> > Subject: [pgadmin-hackers] Bug in CREATE USER script
> >
> >
> > Please change the order of  ENCRYPTED and PASSWORD keywords
> > and quote the password string, or should I do the patch ?
> > Regards !
>
> A patch in diff -c format would be great if you have a few minutes to do
> one :-)
>
> Thanks, Dave.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

*** pgUser.cpp.old	2004-06-22 18:14:17.000000000 +0200
--- pgUser.cpp	2004-08-14 13:47:44.000000000 +0200
***************
*** 58,64 ****
              + wxT("\n\nCREATE USER ") + GetQuotedIdentifier()
              + wxT("\n  WITH SYSID ") + NumToStr(userId);
          if (GetPassword() != wxT("********"))
!             AppendIfFilled(sql, wxT("\n  PASSWORD ENCRYPTED "), GetPassword());
          sql += wxT("\n ");
          if (GetCreateDatabase())    sql += wxT(" CREATEDB");
          else                        sql += wxT(" NOCREATEDB");
--- 58,64 ----
              + wxT("\n\nCREATE USER ") + GetQuotedIdentifier()
              + wxT("\n  WITH SYSID ") + NumToStr(userId);
          if (GetPassword() != wxT("********"))
!             AppendIfFilled(sql, wxT("\n  ENCRYPTED PASSWORD "), qtString(GetPassword()));
          sql += wxT("\n ");
          if (GetCreateDatabase())    sql += wxT(" CREATEDB");
          else                        sql += wxT(" NOCREATEDB");